GeNiaaz / pe

0 stars 0 forks source link

Inconsistent error messages #13

Open GeNiaaz opened 4 years ago

GeNiaaz commented 4 years ago

I received inconsistent error messages for the same mistake:

As shown below I tried to delete an event with an extemely large number, and was given the following error message.

image.png

However, when I used 20 instead, I was given a different message:

image.png

The errors are theoretically the same, and should indeed yield the same error message.

nus-se-bot commented 4 years ago

Team's Response

The message is not inconsistent as the first number put in is larger than the largest value for an integer. When that happens the value is no longer an integer, which makes it the wrong format. Hence, the message about invalid format shows up. Furthermore, the severity has been changed from medium to very low as the program still prevents users from trying to delete visits that are out of range.

The program is still working as intended since the error message targets the error that was given (which is that the index is out of range of the list).

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The system should still recognise and return the same error message, since it is the same issue to the user (who may not be aware of integer limitations in number handling by software). However, given your reasoning, I am compelled to agree that it be changed to veryLow severity as it does indeed still work as intended to prevent entering by the user.


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]