GeNiaaz / pe

0 stars 0 forks source link

Able to create duplicate locations #2

Open GeNiaaz opened 3 years ago

GeNiaaz commented 3 years ago

I was able to create a duplicate location with the same details, but with simply a lower case letter difference. (Namely location 1 and 2)

image.png

This should not be allowed to happen as the ID should not be validated in the lowercase. If it is allowed, there will be confusion between lower and upper case.

nus-se-bot commented 3 years ago

Team's Response

Person Id, valid values of this parameter has been described in the user guide. It was stated that "Person Ids can take any values, and it should be at least 5 characters long." Allowing similar IDs is within expected behaviour, as long as the IDs are not directly identical. This is not a functional bug.

Capture.PNG

It is decided for format to be set as such, because our product is targeted at health officials with no specific target at any country. Hence, different countries may have different Id formats. We are not setting very tight or specific guidelines on the format of the Id because we want VirusTracker to work for different countries. In addition, countries are managing upwards of millions of person data. It is very likely that there will be people with similar Ids among them. Hence, this issue is being rejected.

There is no confusion, since these are inputs from the user himself. In addition, there is a reply from the app to inform the user of what has been done.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your reason]


:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.High]

Reason for disagreement: [replace this with your reason]