search

GeSHi / geshi-1.0

Original version of Generic Syntax Highlighter for PHP
http://qbnz.com/highlighter/
GNU General Public License v2.0
168 stars 100 forks source link

geshi-doc: change letter spacing to normal for readability #118

Closed apjanke closed 4 years ago

apjanke commented 5 years ago

The full 1px letter spacing in the doco page seems a bit excessive, and makes the doc harder to read IMHO. What do you think about reverting it to normal spacing?

Before:

screen shot 2018-12-16 at 2 08 16 am

After:

screen shot 2018-12-16 at 2 08 27 am
BenBE commented 4 years ago

Actually I find that depending on the font a little extra spacing might be justified; in particular for words like programming where the non-spaced version slams the vertical lines in 'mmin' together quite a bit (visible in your screenshots even). Reduced spacing should be tested; I wouldn't quite remove it altogether though.

P.S.: the commit message start is always three letters. In this case chg (change to existing things) would be the indicator I'd use. doc would be acceptable too, but as the indication is mostly to indicate new features (add) vs. bugfixes (fix), behaviour changes (chg), updates (upd) and so on, it'd be less optimal.

apjanke commented 4 years ago

Okay. I'll rustle up a couple other computers and monitors to test on: I'm viewing this on a 27" 5K iMac, so my experience may not be representative of the overall user base.

apjanke commented 4 years ago

I viewed this on a non-Retina monitor, and I thought your current 1px letter spacing actually looks better in that case. I now have no opinion on what the letter spacing should be, since I don't know what your user population's screens are like. I'm withdrawing this PR.

Thanks for working with me!