Geal / Unpapered

An unhosted Instapaper clone
10 stars 2 forks source link

don’t use alert() for errors #9

Closed jancborchardt closed 12 years ago

jancborchardt commented 12 years ago

It’s blocking focuses on the tab with the error, which is annoying if you want to read something in a different tab.

Instead, use an inline alert like the alerts of Twitter Bootstrap – also see issue #8 for that.

Geal commented 12 years ago

Fixed by 48de069957403f3243d14ea1483cdf0640fd3828. These alert() were part of the tutorial code. I replaced them with console.log. Better error messages should be displayed, but not from these parts of the code.

jancborchardt commented 12 years ago

Neato! :rocket: