search

Geal / rust-syslog

Send syslog messages from Rust
MIT License
109 stars 55 forks source link

spurious "ok" printed by syslog::init() #39

Closed semenzato closed 6 years ago

semenzato commented 6 years ago

This code:

      syslog::init(syslog::Facility::LOG_USER,
                     log::LevelFilter::Warn,
                     Some("memd")).expect("cannot initialize syslog");

prints "ok" on the console. Thanks!

"checksum syslog 4.0.0 (registry+https://github.com/rust-lang/crates.io-index)" = "7e5efafb659e873387a9a0e793a09dee1df860c377a54cfecb4af5715d8d51f1"

ckauhaus commented 6 years ago

This is really annoying. Looks like left-over debugging println!()'s in lib.rs L197 and L205. Please remove and release a bugfix version asap!

richardwhiuk commented 6 years ago

https://github.com/Geal/rust-syslog/blob/5867edc2462f0b08afa00c902208b5761e6ade52/src/lib.rs#L197-L205

Should be pretty easy to change these to either debug macros, or just remove them entirely.

daboross commented 6 years ago

There's a PR for it at https://github.com/Geal/rust-syslog/pull/38.

Geal commented 6 years ago

syslog 4.0.1 is released with those println removed