Upgrade to 0.3 of the `time` crate

Geal / rust-syslog

Send syslog messages from Rust

MIT License

109 stars 55 forks source link

Upgrade to 0.3 of the `time` crate #57

Closed jszwedko closed 2 years ago

jszwedko commented 2 years ago

Fixes: #56

Ended up pulling in a bunch of rustfmt changes as well.

Signed-off-by: Jesse Szwedko jesse@szwedko.me

jszwedko commented 2 years ago

Rebased to separate out the rustfmt changes.

6c1e9c5 is just formatting
41a714d is the actual changes

Roguelazer commented 2 years ago

Isn't this just going to make syslog fail on all unix machines since time::OffsetDateTime::now_local() was "fixed" to just always return IndeterminateOffset as part of this CVE?

I think the only way to actually move forward is to have a #[cfg] that, if on unix, just always uses UTC.

jszwedko commented 2 years ago

Good call @Roguelazer . I somehow misread the fix before. I pushed f09e505 which uses UTC when on unix systems.

Roguelazer commented 2 years ago

@Geal is this crate still maintained?

Geal commented 2 years ago

@Roguelazer it has not moved much recently because I focused on other topics, but that issue with the time crate is important enough to make a new release

Geal commented 2 years ago

thanks for the ping though :smiley:

Geal commented 2 years ago

it is now rebased and merged as part of https://github.com/Geal/rust-syslog/commit/7086f02074a01c48c74135ec3d198e2205229479

thank you for the help, this will be released soon in a major version