Gearbox-protocol / core-v3

Other
28 stars 4 forks source link

fix: minor fixes to some informational findings #270

Closed lekhovitsky closed 1 month ago

lekhovitsky commented 1 month ago

Fixes:

StErMi commented 1 month ago

@lekhovitsky I think that the usage of the USE_SAFE_PRICES_FLAG flag (see issue https://github.com/spearbit-audits/review-gearbox/issues/108) should also be documented in the CreditFacadeV3 itself and not only on the PriceOracleV3.

The PriceOracleV3 is where the safe price behavior is configured, but it's the CreditFacadeV3 contract that will tell the oracle to use them or not.

Another issue about the safe price: with the PR https://github.com/Gearbox-protocol/core-v3/pull/268 now also the "adapter logic" of the multicall could enable the USE_SAFE_PRICES_FLAG flag. This scenario is not explicitly documented in the PR and should be.

TLDR: Gearbox should:

StErMi commented 1 month ago

The code looks good and can be merged once the issues described in the above comments are integrated in this PR.

lekhovitsky commented 1 month ago

@StErMi Fixed a typo + added a comment about additional checks in _multicall's NatSpec in the latest commit