Closed lekhovitsky closed 1 month ago
@lekhovitsky part of the unsafe casts / type conversions have been documented via the PR, but there are still some of them that have not been covered by a dev comment.
uint40(block.timestamp)
lossParams.currentCumulativeLoss += uint128(reportedLoss);
lastBlockBorrowed = uint64(block.number)
, currentCreditAccountInfo.lastDebtUpdate = uint64(block.number)
totalBorrowedInBlock = uint128(newDebtInCurrentBlock)
@lekhovitsky would you mind providing an official statement to acknowledge the remaining items to be covered?
@StErMi
block.number
and block.timestamp
casts are safe for sufficiently long time not to worry about it, even on chains with sub-second block times;uint96
);uint128(newDebtInCurrentBlock)
has been documented even before fixes.@lekhovitsky PR #280 cannot be considered in the context of the fix review because it is not part of the PR included in the fix review. I must consider it as not existing unfortunately.
Acknowledges https://github.com/spearbit-audits/review-gearbox/issues/9