search

GearheadLydia / Engine-Sim-Engines

Engines for Engine Sim by Ektorom Software
13 stars 4 forks source link

found bug in Honda_RC211V.mr #1

Open itsnoteasy opened 4 months ago

itsnoteasy commented 4 months ago

I was messing around with upgrading the engine to a larger displacement and found that i couldn't get it to run. angethegreat figured out the issue it was line 99 to 106 the entire function stops air entering the engine. strangely the unmodified file runs fine, but you might want to remove it.

private node add_flow_sample { input lift; input flow; input this; alias output __out: this;

this.add_sample(lift * units.mm, k_28inH2O(flow))

}

GearheadLydia commented 4 months ago

Thanks, will fix. That's a really old engine I haven't maintained in a long time.

GearheadLydia commented 4 months ago

I've been trying to migrate all the engines to new cylinder head code that gets rid of this weirdness, either by directly running the add_sample function, or by using thousandths of an inch instead of millimeters for the lift measurements and falling back to the standard form of add_flow_sample(). The most recent commit to the RC211V doesn't make this engine run smoothly, but it's a lot better than it was.