GearsProgress / Poke_Transporter_GB

A Pokémon Generation I/II to Generation III transfer tool
MIT License
277 stars 6 forks source link

Suggestion for Gen 2 Pokemon Transfers to Avoid Accidental Illegal Pokemon #8

Open PizzaTimeJoshua opened 2 weeks ago

PizzaTimeJoshua commented 2 weeks ago

If possible, I think it would be best if the Gen 2 Pokemon's Game of Origin were also set to Gen 3, instead of Heart Gold/Soul Silver. Reason being ribbons! Suppose you send your beloved Typhlosion to Fire Red. No problem there right? No ribbons to cause legality errors right? Actually, there is a ribbon there. A hidden one for FRLG. The Champion Ribbon you get for beating the Elite 4. If you accidently beat the Elite 4 with you beloved Typhlosion, it'll get the ribbon. Fire Red has no way to view ribbons, making this hidden.

That isn't too bad right? What could a single hidden ribbon do? Wrong! Because the game of Origin is set to HGSS, ANY Pokemon that happens to have the Champion Ribbon but has the Game of Origin set to Gen 4 will be marked as Illegal. Meaning, because you wanted to grind, or play through the game, it will always be Illegal. This is very easy to do unknowingly and since you can't remove ribbons, this is permanent!

GearsProgress commented 2 weeks ago

This is... actually a really good point, thank you!!

I really want to try and keep the Johto met location, just because it keeps them consistent with the rest of the transfers. That being said, it really depends on the legality checks of HOME. Is it banned from HOME or Bank? Is there a way to prevent it from being transferred when sent to the Pal Park? I'm really curious about the legality, as well as what other people think about the incompatibilities. Thank you again for letting me know about this- i definitely did not catch that!!

0xKronos commented 2 weeks ago

I agree with OP, let's assume the following: You transfer a Pokemon from Crystal to Emerald. You do the ribbon challenge and collect every single ribbon from colosseum and emerald. At some point (I believe it's in X & Y?) it will say that the Pokemon traveled through space and time from the Johto region. This, combined with the ribbons from gen 3 makes it technically illegal, right? I don't know if it'll pass Bank / Home, I can't test it yet since I'm waiting for german language support :D But still, having a Gen 2 / Gen 4 Pokemon with Gen 3 ribbons makes it technically illegal, which is a major bummer if you want to do the full ribbon challenge.

PizzaTimeJoshua commented 2 weeks ago

I have just tested this issue. I know from experience that Pokebank will accept any and all Pokemon, no matter how Illegal they are (Magikarp with Oblivion Wing showed no red flags lol).

I spent the last few hours doing exactly this scenario. I got a Pokemon from Crystal and beat the Pokemon League in Fire Red. Sure enough, after I transferred it to Platinum, it had the Champion Ribbon. Met Location was from Johto. I then had my Black Version transfer it to Gen 5 then Bank after that. I had it move directly to Home. Home accepted the Pokemon no problem. But it did maintain the ribbon. Since the summary had it say it came from Johto but it has a Champion Ribbon only obtainable in Gen 3, it likely wouldn't pass any hacked checks if it were to be looked at by anyone with hack checking expertise. Definitely a Disqualification in a VGC tour if it ever was gonna make it that far.

However, you can have the Pokemon in your party with the ribbon with no problem. Not sure how it'll hold in future Pokemon titles tho.

0xKronos commented 1 week ago

Recently I thought again about this topic and had an idea. How feasible would it be to read the player location in Gen 2 and set the game of origin according to the players current region. So, if the player is in a pokemon center in Johto, the game of origin is set to Johto / Gen 4, if the player is in Kanto, the game of origin is set to Kanto / Gen 3. Just an idea / alternative instead of setting the region outright to Kanto for all transports or adding an option during trade. Nonetheless, however you decide to proceed, I want to thank you for this amazing project, this is an absolutely impressive feat of engineering and it's a childhood dream come true! :)