Quality of Life changes

[Kwaice]

Summary of the changes

Phases changes :

• added 2 new phases automation (doInvestigationPhase and doEnemyPhase) and moved all phases in a new phase_change_automation.py

  • Mythose Phase change : Added auto replenish cards automation (shameless copy from Pilunte script)
  • Investigation Phase : Added Amanda automation (prompts player to put a card under Amanda) and Joe automation (reveals Hunch Deck top card and shuffles Hunch Deck if card still on top)
  • Enemy Phase : Targets ready Hunter enemies for clarity
  • Upkeep Phase : Added Patrice upkeep automation, Dream-enhancing Serum and Forced Learning automation
  • Added a Card per Upkeep and Resource per Upkeep option (resource image might need some work)

  

Blurse:

• moved all Blurse functions into a new blurse.py file
• added countBless and countCurse to count total Bless/Curse in chaos bag or sealed on cards (used for Rite of Sanctification, Nephthys or Holy Spear automations)

Player card automation:

• Added most of the missing cards (tell me if i ommitted some)

• Cards that choose another investigator use a menu displaying the color and name of the investigators

• Added a AttachTo function, used to attach cards to other cards (used for Bagpack, Ancestral Knowledge, Stick to the Plan, Sefina and so on..)

Global changes:

• changed the Draw function:
  • Warns the player if his deck is empty and to take an horror
  • Checks for Dream-Enhancing Serum automation
• changed DrawMany to use the draw function
• changed Mulligan: now usable for two handed solo and automatically removes Weaknesses excepted Tarot Weaknesses
• changed RandomDiscard: now checks for Hidden cards
• changed drawOpeningHand:
  • checks for Studious
  • Joe Diamond automation: asks for player if he would like to automate the Hunch Deck and filters insight events if so
  • Sefina Rousseau automation: asks for player if he would like to automate Sefina starting hand and attaches chosen events under Sefina if so
• changed playerSetup:
  • Stick to the Plan and Ancestral Knowledge automation
  • "Another Day, Another Dollar" and Indebted automation
• added Akachi autocharges +1
• nextEncounter changes:
  • notifies player if encounter deck is empty (mainly useful for The Circle Undone)
  • Hidden cards are automatically added facedown to the table
• Tekeli-li:
  • using ctrl+4 lets the player chose an investigator to shuffle a Tekeli-li card in his/her deck
  • Double-clicking a Tekeli-li card moves it back to the bottom of the special deck

[KenDdoox]

I've checked and they work, but there are a few things we can get going:

Bug:

1. Forced Learning doesn't work correctly (for case where Card draw = 1):

   • Currently: You're selecting from the card just drawn and the last card in your hand -> Doesn't even show popup when your hand is empty and you just draws normally
   • Expectation: You're supposed to draw 2, then choose 1 to discard.
   • Edit: I realized that there's a "Card draw" counter on the stats bar, though when you load a deck with this card, this number should be automatically set to 2 (same case with Jenny and resource counter). Additionally, when this number is set to more than 2, the popup still shows only the last 2 cards to discard 1 of them. -> We should hide both these counters (card draw & resource upkeep) and make it work only in background, since a player could change it by accident and cause unnecessary trouble.

2. Dream-Enhancing Serum when 2 copies are on the table (might affect other specific card-automation cases):

   • Currently: When both DES are on the table and can trigger, both are exhausted and you only draw 1 card.
   • Expectation: The popup shows up one at a time, one for each copy the player controls (Black Market or Teamwork may cause a player to have more than 2 copies). -> This leads to the note: Player card automation should work based on cards they control.

3. Notification banner doesn't clear old messages

   • Currently: All previous messages are still kept, even when they're not relevant anymore, and are displayed to the right of the most recent message.
   • Expectation: Clear all old messages and only displays the ones that trigger the banner (multiple triggers at the same time allowed).

4. Ancestral Knowledge doesn't work correctly:

   • Currently: You have to trigger it with double click, then choose 5 skills. After that you get a popup to draw opening hand.
   • Expectation: Automatically takes out 5 random skills, then prompts you to draw opening hand.

5. Stick to the Plan still allows duplicates:

   • Currently: STTP popup shows duplicate cards, and you can select duplicates to be attached to STTP.
   • Expectation: The popup should only show 1 copy even if you have multiple. Either that, or disable selecting the same card more than once in the popup.

Enhancement:

1. Resource token image can be a scaled down version of the current one in Markers folder
2. Cards only exhaust when they have the words "exhaust" on them when double-clicked.
3. Cards that seal tokens on it should be double-clickable: Card list
4. Attached cards should be faceup (technically not correct but for convenience, it's better faceup)
5. Astronomical Atlas takes the top card of the deck and attach it to the Atlas, if it's a weakness, reveals it and keeps it on top of the deck
6. Survivor's pulling things out from the discard pile: Card list. At the most basic level, we should get Scavenging, Resourceful, Scrounge for Supplies, True Survivor and Prof. William Webb. Wendy's Amulet (both versions) could be a good card to work on.
7. Cards that search: Card list. Could we move all the cards that use automation to a separate file and reference that in the script? This will make it much easier to maintain with each new batch of cards.
8. Diana's extra starting Dark Insight in hand that can't be mulligan
9. Jenny's extra resource at up keep (should automatically change the value of "Resource per upkeep" on deck load)
10. Preston's Family Inheritance replenish at start of investigation phase (technically his turn but this is still fine)
11. Luke's Dream Gate should start in play since it's going to happen sooner or later
12. Norman always reveals top card of deck. The Harbinger forbids all deck automation (including draw or deck manipulation cards), except removing it manually (double clicking it or drag it to the discard pile).
13. Mary's auto bless at first Investigation phase and every end of upkeep (start of mythos)

Extra enhancement (not high priority):

1. Card state on table can affect the stats bar:

   • Calvin's health & sanity values map to his stats
   • Cards being on the table maps to hand size: Card list
   • Parallel Daisy's tomes on table map to her Willpower

2. Investigator's elder sign can be triggered by double-clicking on the investigator

   • Mandy and Leo searches their deck
   • Nathaniel returns event from discard
   • Mary adds bless (not necessary but it can be done through this)
   • Joe moves an Insight event from discard to bottom of Hunch deck
   • Patrice chooses one card to keep in discard and shuffle the rest into deck
   • Silas takes a skill in discard and places it on table

[KenDdoox]

Bug:

1. Astronomical Atlas:

   • CurrenTly: Is unclickable when your deck is empty. Double click shows popup.
   • Expectation: Could show a message in the log about looking at an empty deck. Additionally, this card doesn't really need the popup, since you will just take the card out from underneath it and reveal it to commit it anyway.

2. Shard of the Void:

   • Currently: You can choose to seal a revealed "0" token when there isn't one, and the count goes up, and then release them back into the bag (or delete the card to do all at once) to add in new "0" tokens each time you do this. You can also close the popup and the count still goes up.
   • Expectation: You cannot choose to seal a revealed "0" token when there isn't one on the table.

3. Sealing cards:

   • Currently: Deleting cards that have sealed tokens on them returns the tokens to the bag, which is good. But you will lose the tokens permanently when you move it manually (drag-drop) it to hand or discard pile or any other pile.
   • Suggestion: For these sealing cards, it would be better to just make them all work like how Premonition or Unrelenting is doing, i.e. pulling the actual tokens out of the bag and seal them on the card.

4. Resourceful:

   • Currently: Pull all cards out into the popup.
   • Expectation: Should only pull Survivor cards out.

5. Family Inheritance:

   • Currently: Keep all resources when investigation phase ends.
   • Expectation: Should remove all resources on it when enemy phase begins. (Works similarly with the replenish cards, only different timing window)

Other:

1. Norman and his things: Could we do something for him and his signature cards like Joe's Hunch deck?
2. Sister Mary's end of round bless

[KenDdoox]

More on Astronomical Atlas:

• Changed opinion from previous: It appears that the popup is a necessary part of the automation, since it affects the other cards attached to the Atlas. My apologies for not testing it deeply the first round. We should keep the popup :D

Bug 1:

• Currently: When the card is ready, you trigger it, it exhausts. When it is already exhausted, you have to trigger it twice to use it again: once to ready it, once to commit the card underneath it.
• Expectation: This card can still be triggered when it is exhausted. Triggering it when exhausted won't ready it.
• Suggestion: This leads back to my previous point about standardizing double click actions on player cards: Only exhaust cards when they have the word exhaust in it, and doubleclicking them won't do anything, except when there is something specific like the Atlas, which will be covered case-by-case automation.

Bug 2:

• Currently: When the card already has other cards attached to it, and it leaves the table by any reason (deleting or dragging it somewhere else), the attached cards remain "linked" to the Atlas, even when those cards get deleted/moved to piles as well. And then when you try to use the Atlas again, all those cards still count towards the 5-card limit, regardless of where the previously attached cards went. Choosing to commit the cards still shows all previously attached cards.
• Expectation: The attachment should "break" when the cards (both host and attached) get moved out of the table.

Bug 3:

• Currently: All copies of Atlas on the table (at least for one player) share the same script, using the same attached cards and attachment limit.
• Expectation: Different Atlas should be separate entities, same rule as Dream Enhancing Serum.
• Suggestion: We should consolidate the scripts for these "different copy" cards into something more robust to future proof against similar cases. Possible cases: cards that trigger automatically at a specific time/under specific conditions; cards that run on a multi-step script.

[KenDdoox]

1. Livre d'Eibon bug:

   • Currently: When trying to swap a card while The Harbinger is locking the deck, it just puts the card on top of the deck.
   • Expectation: The Harbinger locking the deck stops all deck manipulation.
   • Suggestion: Also whispers in the log when trying to search for cards while the deck is locked, and when trying to trigger an Astronomical Atlas. You could also just bring the card onto the table when committing it (not necessary).

2. Astronomical Atlas:

   • Suggestion: If the top card is a weakness and can't be put under the Atlas, that top card should be automatically peeked for the owner.