Gecode / gecode

Generic Constraint Development Environment
https://www.gecode.org
Other
283 stars 76 forks source link

Operators and constructors added to avoid -Wdeprecated-copy messages #129

Closed pkeir closed 3 years ago

pkeir commented 3 years ago

These two commits:

1) add default copy assignment operators where their implicit definition is now (C++11) deprecated due to the presence of user-declared copy constructors.

2) add default copy constructors where their implicit definition is now (C++11) deprecated due to the presence of user-declared copy assignment operators.

This eliminates the warning messages which come from -Wdeprecated-copy (controlled by -Wextra). These warning messages form the bulk of those highlighted in Issue #118.

lgtm-com[bot] commented 3 years ago

This pull request fixes 18 alerts when merging b252ecbf082df0d32bad990b878adb1e5d24a4f3 into 07493493368bc7859b962e010e07f0a1b590c9da - view on LGTM.com

fixed alerts:

zayenz commented 3 years ago

Thanks for this, it's been on my todo-list for quite a while. I will check it as soon as I can.

zayenz commented 3 years ago

I've looked through the code and it seems to be as one would want it.

Thanks again.