search

Gecode / gecode

Generic Constraint Development Environment
https://www.gecode.org
Other
275 stars 76 forks source link

cmake: Remove unused checks. #184

Closed waywardmonkeys closed 9 months ago

waywardmonkeys commented 9 months ago

None of the header checks were used for that and can be removed.

One was used to check for sys/time.h and then enable gettimeofday() so we can instead just check for the gettimeofday() function instead.

Remove unused check for size of int.

Remove unused check for getpagesize().

Remove GECODE_HAS_UNISTD_H from the config header as it isn't used or set by anything (any longer).

waywardmonkeys commented 9 months ago

Many of these didn't mirror checks in configure.ac but did mirror checks generated by it in configure. They weren't used though and many not necessary in 2023.

waywardmonkeys commented 9 months ago

@zayenz Checking in on this as if this can land, I have some other things that I'd like to submit so that I don't lose track of them.

zayenz commented 9 months ago

@waywardmonkeys Thanks for pinging me again. I started a new job this monday, so been a bit busy.

AFAICS, this looks like a good cleanup!