LGTM fixes - Githubissues

Gecode / gecode

Generic Constraint Development Environment

https://www.gecode.org

Other

283 stars 76 forks source link

LGTM fixes #84

Closed zayenz closed 4 years ago

zayenz commented 4 years ago

LGTM.com is a code analysis service. Their analysis of the Gecode source code is available here: https://lgtm.com/projects/g/Gecode/gecode/?mode=list

This branch fixes several of the warnings, including

A mismatched alloc with delete
Potential loss of precision in some multiplications
Missing path compression in the sorted propagator

There are several issues still left to investigate

Many copies of copy constructors without assignment operators
Many large objects passed by value

There are also a few warnings about usage of goto, which are not as interesting for us to fix (the usages are well known).

lgtm-com[bot] commented 4 years ago

This pull request fixes 9 alerts when merging 7e107249a492c67d586e52bdf7b871246d7cb012 into 87a464b9d7d67616c1b4c6b98600d38a782d014b - view on LGTM.com

fixed alerts:

4 for Empty branch of conditional
2 for Multiplication result converted to larger type
1 for Comparison result is always the same
1 for FIXME comment
1 for Mismatching new/free or malloc/delete