search

GedMarc / bootstrap4-dialog

bootstrap4 compatible modal dialog based on nakupanda.github.io/bootstrap3-dialog
https://nakupanda.github.io/bootstrap3-dialog/
65 stars 31 forks source link

Wladiz2001 patch 1 #40

Closed wladiz2001 closed 2 years ago

wladiz2001 commented 2 years ago

Add verticalCentered option

This option allows the modal to be centered vertically, verticalCentered: true/false (default: false)

GedMarc commented 2 years ago

This looks great thank you! Seems like you got it all! :)

Which minify did you use for the .js min?

wladiz2001 commented 2 years ago

I use UglifyJS 3 for minify, This tool decreases the size a little more than the one used previously.

GedMarc commented 2 years ago

ok i'm going to need to bring this in manually :) I can't risk doing an update where there may be malicious code in the min file,

For reference, please only update the source files, we minify and build on our side before we set out a release, this is pretty standard practice

GedMarc commented 2 years ago

@wladiz2001 can you please remove the min file from the commit? find time stretched out sorry :(

wladiz2001 commented 2 years ago

Ok, I delete de min files. Thanks for the explanation