search

GedMarc / layout

jQuery UI Layout v1.x plugin
Other
54 stars 24 forks source link

$.isArray is deprecated #12

Closed melloware closed 4 years ago

melloware commented 4 years ago

jquery-migrate-3.2.0.js:102 JQMIGRATE: jQuery.isArray is deprecated; use Array.isArray

When running JqMigrate gettting this warning on Layout.

Hope all is well!

Sorry forgot to mention using latest JQMigrate 3.2.0

GedMarc commented 4 years ago

100% - let me take a look

melloware commented 4 years ago

Also

jquery-migrate-3.2.0.js:102 JQMIGRATE: jQuery.trim is deprecated; use String.prototype.trim

melloware commented 4 years ago

Sorry two more:

jquery-migrate-3.2.0.js:102 JQMIGRATE: jQuery.type is deprecated

JQMIGRATE: jQuery.isFunction() is deprecated

GedMarc commented 4 years ago

do you think I need to include the source files for jquery? perhaps the min files are not spitting out the debug errors xD

image

melloware commented 4 years ago

Hmm I think I just have the JQMigrate and the JQ 3.5.0 Min JS installed.

melloware commented 4 years ago

Maybe make sure to load Migrate after Jquery?

<script src="https://code.jquery.com/jquery-3.5.0.js"></script>
<script src="https://code.jquery.com/jquery-migrate-3.2.0.js"></script>
melloware commented 4 years ago

Did you get this worked out?

GedMarc commented 4 years ago

yeah almost, the day job went a bit crazy today :) sorry please allow till the end of the day

melloware commented 4 years ago

Oh no worries just seeing if you needed any help! Much appreciated for the work!

GedMarc commented 4 years ago

Have not forgotten about you!!!

The switch to Arrays. is more than just syntax change - it's underway

melloware commented 4 years ago

Excellent. I will review all your changes once you are done.

GedMarc commented 4 years ago

Before Fixes -

image

GedMarc commented 4 years ago

All of the migrate warnings have been updated - The warnings that come up now are from JQuery UI itself XD Don't suppose you know anyone in those circles?

GedMarc commented 4 years ago

https://github.com/GedMarc/layout/releases/tag/V1.7.4

melloware commented 4 years ago

Thanks!