Review Code You Lazy Swine

[GeeH]

Please review the code and give your opinions @ocramius.

[Ocramius]

In general, all files have messed up headers/docblocks which I won't review as it's just noise. License should be included in files.

UglyDi\UglyDi:

• this is not needed: it's an ancient ZF2 practice that only @EvanDotPro uses.
• Unless UglyDi is designed for inheritance (which doesn't seem to be the case), all properties should be made private.
• null === $config
• __construct should not return a value
• you should probably avoid I/O operations in __construct by simply not allowing a file to be passed in
• you should use specialized exception types
• is null an actual allowed instantiated type?
• type-hint should be array
• array hint
• this is a responsibility of ReflectionClass: no need to throw an exception manually, but eventually catch and re-throw a specialized exception if needed
• return directly
• avoid repeating method calls, as the return value may change, cache the return value of $reflector->getConstructor() instead
• the generator seems to write to a file and also retrieve the file name, which seems like a violation to me
• instead of directly require-ing a file, the container should rely on the generator for requiring the factory
• naming suggests that only objects are being created
• no need to use call_user_func starting from PHP 5.4+
• the return value is not a class name, but an object
• UglyDi\UglyDi#getReflector() should probably not be public
• UglyDi\UglyDi#setCreatedClass() should probably not be public
• UglyDi\UglyDi#getAlwaysGenerate() should probably not be public
• UglyDi\UglyDi#setAlwaysGenerate() should probably not be public
• use constructor options instead of setters/getters

UglyDi\Module:

The entire class should probably be avoided, as this is a library more than a module

• antiquate technique
• known bad practice: if needed, use getConfig

UglyDi\Exception\InvalidCacheDirException:

• should implement an UglyDi exception interface for generic UglyDi exception catching
• should present named static constructors instead of relying on the default __construct, which is not specific to the use-cases of UglyDi

UglyDi\Exception\InvalidClassException:

• should implement an UglyDi exception interface for generic UglyDi exception catching
• should present named static constructors instead of relying on the default __construct, which is not specific to the use-cases of UglyDi

UglyDi\Generator\GeneratorInterface:

• exists and getFileName can be simplified into load, which returns a callable
• generateFactory is not needed if load is implemented, as the need for code-generation becomes an implementation detail of the generator
• $parameters is not validable in PHP due to the lack of generics, therefore, I'd expect the interface to define an @throws docblock
• return types should be specified

UglyDi\Generator\Generator:

• the slugifier does not ensure uniqueness of the slugged json string
• file names may become too long for windows systems, consider hashing+validating instead

Further reviews will be provided if a pull request is provided.