Model options is now situated in separated classes
Renderer options is now situated in separated classes too
Model options passed to constructor now change model behaviour (options don't have any effect before update)
CS fixes
Code cleanup
Some helpers was modified
Create a lot of unexsist property in test classes
* Create a lot of new tests
Comment
User: @prolic
Created On: 2013-03-02T19:33:37Z
Updated At: 2013-03-02T19:33:37Z
Body
looks good on first sight
Comment
User: @weierophinney
Created On: 2013-03-11T21:39:20Z
Updated At: 2013-03-11T21:39:20Z
Body
I think there are some great ideas here. However, you've removed methods that existed on the view models, and also removed methods from interfaces -- which means that functionality that was consumed before no longer will work. In other words, it's not backwards compatible.
That said, I still think they're good ideas; I've simply changed the milestone to 3.0.0, as that will be the earliest we can make these changes.
Comment
User: @MatyCZ
Created On: 2013-06-12T10:09:52Z
Updated At: 2013-06-12T10:09:52Z
Body
There is one Test which fails but I don't understand why:
This issue has been moved from the
zendframeworkrepository as part of the bug migration program as outlined here - http://framework.zend.com/blog/2016-04-11-issue-closures.htmlOriginal Issue: https://api.github.com/repos/zendframework/zendframework/issues/3935 User: @MatyCZ Created On: 2013-03-02T15:28:49Z Updated At: 2014-06-12T10:51:43Z Body
* Create a lot of new tests
Comment
User: @prolic Created On: 2013-03-02T19:33:37Z Updated At: 2013-03-02T19:33:37Z Body
looks good on first sight
Comment
User: @weierophinney Created On: 2013-03-11T21:39:20Z Updated At: 2013-03-11T21:39:20Z Body I think there are some great ideas here. However, you've removed methods that existed on the view models, and also removed methods from interfaces -- which means that functionality that was consumed before no longer will work. In other words, it's not backwards compatible.
That said, I still think they're good ideas; I've simply changed the milestone to 3.0.0, as that will be the earliest we can make these changes.
Comment
User: @MatyCZ Created On: 2013-06-12T10:09:52Z Updated At: 2013-06-12T10:09:52Z Body There is one Test which fails but I don't understand why:
Zend\View\ViewTest::testModelFromEventIsUsedByRenderer