GeeWee / BetterHostedServices

Fixed a wide variety of issues that have to do with Hosted Services and BackgroundServices, such as error handling and the abillity to access them via the DI.

MIT License

27 stars 4 forks source link

Set of API improvements #29

Closed ProMix0 closed 2 years ago

ProMix0 commented 2 years ago

Closes #24 Closes #25 Closes #26 Closes #27 Closes #28

Also it unintended resolve #22

ProMix0 commented 2 years ago

30 should help

ProMix0 commented 2 years ago

This commits will fix build Action

GeeWee commented 2 years ago

Also CI seems to be failing

ProMix0 commented 2 years ago

It's strange. My fork pass tests successful Fork

I will try to resolve this

ProMix0 commented 2 years ago

I really have no idea why tests (I mean test - PeriodicTask_ShouldContinueRunningTasks_IfFailureModeIsSetToRetry()) don't passes

I guess this behavior undefined. But don't know why

GeeWee commented 2 years ago

Ah, let me try to dive into the CI situation - that does seem super weird. It might take a week or so before I get around to it though.

GeeWee commented 2 years ago

Turns out it's probably going to take longer - real life's getting in the way. You're not forgotten though.

ProMix0 commented 2 years ago

Maybe I can help?

GeeWee commented 2 years ago

I mean absolutely do feel free to dive into the CI issue - there is a chance it's just a flaky test

ProMix0 commented 2 years ago

Can you try to run CI again? My branch passed tests three times in a row. If now problem isn't resolved... so, I will think a lot :)

GeeWee commented 2 years ago

Still seems to be failing..! :/

ProMix0 commented 2 years ago

Finally, I found failed test I guess latest commit may fix that issue

ProMix0 commented 2 years ago

I rewrote tests. Yes, it's don't work again I have a versions that it's a kind of multithread issue

So, I don't know. Tomorrow I will add loggers to tests

GeeWee commented 2 years ago

After reflecting on the amount of time I have to maintain this project, I don't think I will have time to handle PR's and stuff unfortunately.

However, if you'd like to make a fork and publish that to nuget under a different name, I would be happy to link to it from this projects README