GeeWee / django-auto-prefetching

Automatic prefetching for Django
MIT License
231 stars 18 forks source link

Additionally test under Python 3.6 #16

Closed johnthagen closed 4 years ago

GeeWee commented 4 years ago

Sorry for taking so long to get back to you. Really appreciate the pull requests, and I've merged the other one in.

The tests seem to be failing on python 3.6 though, can you take a look at it before I merge it in?

johnthagen commented 4 years ago

I'm not sure familiar with how CircleCI works,

It looks like somehow pipenv installed for Python 3.6 is trying to load a Python 3.7 .so file.

[pipenv.exceptions.InstallError]:   File "/usr/local/lib/python3.6/site-packages/pipenv/cli/command.py", line 615, in sync
[pipenv.exceptions.InstallError]:       pypi_mirror=state.pypi_mirror,
[pipenv.exceptions.InstallError]:   File "/usr/local/lib/python3.6/site-packages/pipenv/core.py", line 2611, in do_sync
[pipenv.exceptions.InstallError]:       system=system,
[pipenv.exceptions.InstallError]:   File "/usr/local/lib/python3.6/site-packages/pipenv/core.py", line 1253, in do_init
[pipenv.exceptions.InstallError]:       pypi_mirror=pypi_mirror,
[pipenv.exceptions.InstallError]:   File "/usr/local/lib/python3.6/site-packages/pipenv/core.py", line 862, in do_install_dependencies
[pipenv.exceptions.InstallError]:       _cleanup_procs(procs, False, failed_deps_queue, retry=False)
[pipenv.exceptions.InstallError]:   File "/usr/local/lib/python3.6/site-packages/pipenv/core.py", line 681, in _cleanup_procs
[pipenv.exceptions.InstallError]:       raise exceptions.InstallError(c.dep.name, extra=err_lines)
[pipenv.exceptions.InstallError]: []
[pipenv.exceptions.InstallError]: ['/home/circleci/repo/.venv/bin/python: error while loading shared libraries: libpython3.7m.so.1.0: cannot open shared object file: No such file or directory']
ERROR: ERROR: Package installation failed...
GeeWee commented 4 years ago

After a little bit of fiddling I managed to make it work with tox and a custom docker image. Thanks for the PR!