search

Geeetech3D / Smartto-Eclipse

3D printer firmware and hardware of for stm32
GNU General Public License v2.0
25 stars 16 forks source link

Discrepency in Eclipse project, IAR project, and firmware releases #21

Closed thatjoshguy closed 5 years ago

thatjoshguy commented 6 years ago

What is the proper procedure for contributing code to the SMARTTO project? Currently there are two branches, each with two different projects and code bases (Eclipse and IAR).

Changes I submitted that were merged into the Eclipse project had errors that were corrected in the IAR code updated by (I am assuming) Geetech.

Why are we maintaining two separate versions of essentially the same code? Isn't this going to cause issues further down the line? Obviously someone noticed the error in my pull request, why was it accepted? It should have been rejected so I could fix it and then merged into master. Why was it only fixed in the IAR version?

I want to support this project and help SMARTTO grow, but I am afraid that will be difficult unless it is made clear how to go about this and we move to a single code base/project. Eclipse is free and easy to use so I think it makes a good choice to promote it as the primary code base

thatjoshguy commented 6 years ago

On a related note: when compiling from Eclipse I get a single .bin file but normally the firmware releases include two files, one for main board and one for screen. Is there a different way I should compile for testing, or does the Eclipse project not include the screen firmware?

Geeetech3D commented 6 years ago

Thanks, Josh. We are working on it .