search

Geeetech3D / Smartto-Eclipse

3D printer firmware and hardware of for stm32
GNU General Public License v2.0
26 stars 16 forks source link

Blank new line before responses #26

Open wlky opened 6 years ago

wlky commented 6 years ago

Before most responses the printer adds an empty new line. This seems to prevent AstroPrint from working and is in my eyes unnecessary extra bits on the serial connection. I think the reason for the new line can be found here: https://github.com/Geeetech3D/Smartto-Eclipse/blob/ad5f3b41708216b402eb1f2adc2da9230d35acd3/STM32f103r/src/serial_print.c#L589

Just removing the "\r\n" before the "ok" would fix it. Or is this blank line useful in any way?

alexwoo1900 commented 6 years ago

Thanks @wlky That's a bug, we will remove it in next version