search

Geek-in-Training / Firefox-Addon-Bar--Restored

Adds back the addon bar to Firefox with the new Australis theme (Firefox 29 and up).
https://addons.mozilla.org/firefox/addon/the-addon-bar/
MIT License
10 stars 10 forks source link

a mistake #12

Closed 999946 closed 10 years ago

999946 commented 10 years ago

GetMigratedItems was a mistake You should use this method. CustomizableUI.getWidgetIdsInArea(areaName);

Geek-in-Training commented 10 years ago

Which areaName were you thinking of? The problem with using CustomizableUI.getWidgetIdsInArea("nav-bar"); is that the user may have some icons there that they want to be there. I would also have to manually filter out things such as the home button and the downloads button.

999946 commented 10 years ago

CustomizableUI.getWidgetIdsInArea("GiT-addon-bar");

Geek-in-Training commented 10 years ago

I'm sorry, I fail to see how this would replace getMigratedItems(). It returns an array of item IDs that have been migrated off the old addon-bar to the nav-bar, whereas CustomizableUI.getWidgetIdsInArea("GiT-addon-bar"); would return an array of IDs that are already in my newly added addon bar.