Geek-in-Training / Firefox-Addon-Bar--Restored

Adds back the addon bar to Firefox with the new Australis theme (Firefox 29 and up).
https://addons.mozilla.org/firefox/addon/the-addon-bar/
MIT License
10 stars 10 forks source link

License issues #41

Open davidhedlund opened 7 years ago

davidhedlund commented 7 years ago

I'm an administrator on the Free Software Directory. Your program is free software so in principle it should be listed there, and I'd like to add it. But it has some problems in showing what its license is. Would you please fix them, for the sake of users and other developers?

Once your version with fixed license issues is public available on https://addons.mozilla.org/en-US/firefox/addon/the-addon-bar/ we will review it, and if it meet our requirement I will approve http://directory.fsf.org/wiki/The_Addon-Bar_(Restored). Once approved it will be listed on the official GNU IceCat add-on list at https://directory.fsf.org/wiki/IceCat. GNU IceCat is the GNU variant of Firefox.

See https://addons.mozilla.org/en-US/firefox/addon/librejs/ if you want to study a well licensed add-on.

Issues

No full license file

There are no full copy of the license file

The root directory don't have a COPYING file with a copy of the software license. A plain text version of can be found here: http://directory.fsf.org/wiki/License:X11

Lack of license headers in each file

There are no license notices in the non-trivial source files

The source files in The Addon Bar (Restored) don't have notices saying you are the copyright holder and/or that they are released under MIT/X11 License. I'm writing to ask you to please put a notice on each nontrivial source file.

Selecting a license on a website that hosts the add-on (like addons.mozilla.org), will only show it there, the source files won't be modified.

First, here's why license notices are needed.

The purpose of a license notice is to state formally that a certain file may be used under the terms of a particular license.

The MIT License, like most free software licenses, applies to whatever material is released under that license. It does not say anything about which programs are released that way.

Therefore, simply including a copy of the MIT License with some code does not release the code under the terms of the MIT License. To do that, you need a license notice, which says, more or less, "We the copyright holders release this code under the MIT License."

The source files should be accompanied by a copyright notice, which says who "we" copyright holders are. That takes the form "Copyright YEAR NAME".

For the MIT License, there are two other reasons for a license notice: to say which version of the MIT License applies, and (for MIT/X11 License), to say whether the MIT License's option of GPL compatibility applies. It is enabled by default in MIT/X11 License, but users should have an explicit statement of where things stand for any particular code. The license notice is where you specify this.

Why should the license notice be on each source file? Because doing it at the package level is error-prone.

In the free software community, it is not unusual to copy a file from a free program into some other context. If the source file doesn't have its own license notice, then its licensing comes from the original context. In the other context, its licensing may not be clear. It may not be stated at all, or it could be stated wrong. For instance, what if the other program says, "This program is released under Apache 2.0", or "This program is released under GNU GPL, version 3 or any later version published by the Free Software Foundation."

The result would be to misinform users about the file's licensing.

People sometimes copy part of a file, too. If the file has a license notice, people know to preserve that notice when copying part of the file's code. Otherwise, the licensing will probably get lost.

A different problem can happen if you copy code into The Addon Bar (Restored) from some other package. Your package-level license notice would say it is under MIT/X11 License, but what if it actually carries some other license, such as Apache 2.0, or GPL Version 3 or later?

Keeping a license notice in each file is the way to reliably show users what their rights are. Please don't let uncertainty creep in.

You've made a decision about the license -- would you please announce it in a way that won't get forgotten?

Other people can use your work with bad intentions, even if the mistake were honestly unintentional. That is why, unfortunately, we have to take lots of time with verifying the legality of everything.

See https://www.gnu.org/licenses/gpl-howto.en.html for how to apply license notices.

Licenseutils

References

These issues are compatible with the policy listed in Free Software Directory, Requirements.