search

GeekHaven / Leave-Application-Portal

Leave application portal for IIITA to speed up leave approval process
https://leave-application-portal.herokuapp.com/
8 stars 20 forks source link

make extension lowercase in application_submission script it is not matching the extension array if extension is in uppercase #89

Closed prateek76 closed 5 years ago

prateek76 commented 5 years ago

Fix for multiple file uploads

thesmallstar commented 5 years ago

@prateek76 I just tested it. Seems to be working fine.

prateek76 commented 5 years ago

It's not appending file names to database only last file is being added

thesmallstar commented 5 years ago

Worked fine until I made the last pr, I think I messed something, I will fix it.

thesmallstar commented 5 years ago

I merged with master and did the following test:

  1. Uplload folder before form submission, ff2
  2. Added files to form: fff1
  3. UPload folder after submission: ff4
  4. The links in dashboard: ffr5

Am I missing anything? All the 1-2-3 links in dashboard also works correctly.

prateek76 commented 5 years ago

@thesmallstar ok then problem may be on my side maybe xampp is not working properly 👍

thesmallstar commented 5 years ago

@prateek76 Yes, please test, I am also doing it I will comment if I find a bug. :)

prateek76 commented 5 years ago

@thesmallstar i got the error the images i was uploading was having extension in uppercase , please make extension to lowercase as it was before

thesmallstar commented 5 years ago

Okay, I am doing it.

thesmallstar commented 5 years ago

You mean we need to accept both lowercase and upper case I.e png and PNG Both are acceptable, or anything else. Update: I got what you are saying,I am on it.

prateek76 commented 5 years ago

also change redirection linkto "adminLogin.php" from "adminlogin" when admin logout in adminlogout.php locally it dont affect but on other servers it will show 404, it can be case sensitive , like on 000webhostapp deployment

thesmallstar commented 5 years ago

@prateek76 yes, it will be a issue on Linux servers. I will make the change