search

GeekHaven / Leave-Application-Portal

Leave application portal for IIITA to speed up leave approval process
https://leave-application-portal.herokuapp.com/
8 stars 20 forks source link

make filters work properly like if there is no pending applications on clicking pending application tab table should show no pending applications #93

Closed prateek76 closed 5 years ago

prateek76 commented 5 years ago

check here - https://iec2017029.000webhostapp.com/

thesmallstar commented 5 years ago

I have made a PR for two issues, Can i claim this?

thesmallstar commented 5 years ago

@prateek76 I am little confused what else comes under this issue?, I thought of No applications should be written if there are no applications in the dashboard, and 1-2 more in admin dashboard. Anything else you would suggest?

prateek76 commented 5 years ago

@thesmallstar like if there are no pending applications but there are 2 accepted applications so if you are in all applications tab and click on pending applications tab all application are displayed now this is the problem you have to show no pending applications in the table

thesmallstar commented 5 years ago

@prateek76 ok :)

thesmallstar commented 5 years ago

I Checked all the sections, Here is what I saw: I dont see a bug, am I missing something? m3 m5 m1 m2

prateek76 commented 5 years ago

check here https://iec2017029.000webhostapp.com/admin_dashboard.php @thesmallstar click on new applications as there is no new application it should not display any row in the table instead no new application should be shown