search

GeekZoneHQ / web

Software to power the Geek.Zone website and apps
http://geek.zone/web
GNU General Public License v3.0
19 stars 29 forks source link

Performance Budget Check #210

Open jamesgeddes opened 3 years ago

jamesgeddes commented 3 years ago

Add check to ensure that proposed deployment does not breach our performance budget

budget = kb

Impact

High

Urgency

Later

jamesgeddes commented 3 years ago

Made some progress on this today. Looks like Lighthouse might be a good direction to go, but it does rely on package.json so may require some yak shaving.

CarwynNelson commented 3 years ago

We do now have a package.json since we brought in tailwindcss, but I'm not sure how accurate lighthouse will be in this scenario?

jamesgeddes commented 3 years ago

ah I didn't know about that. this branch also has a package.json so I will remove it.

Re accuracy, I was under the impression that the intention of lighthouse is to test performance, is that not correct?

Moving to P2 as this is not absolutely necessary to get the MVP working.

CarwynNelson commented 3 years ago

Re accuracy, I was under the impression that the intention of lighthouse is to test performance, is that not correct?

I can't quite remember why I wrote this comment, so I guess this is a lesson for me to just add the whole context to a comment and not assume I'll be able to explain it later. :facepalm: