Issue Closed Notification

GeekZoneHQ / web

Software to power the Geek.Zone website and apps

http://geek.zone/web

GNU General Public License v3.0

19 stars 29 forks source link

Issue Closed Notification #425

Open jamesgeddes opened 2 years ago

jamesgeddes commented 2 years ago

What's your idea?

Help us to celebrate our wins by sending issue closed notifications to the DISCORD_DEV_WEBHOOK webhook.

Brownie points

Could randomly select from a list of celebration messages, for example,

[assignee name] hit issue [repo name]#[issue number] out of the park!
[assignee name] just smashed [repo name]#[issue number]!
[assignee name] showed [repo name]#[issue number] who's boss!
[repo name]#[issue number] was vanquished by name!
[repo name]#[issue number] has been promoted to prod thanks to name!
[repo name]#[issue number] was just shown the definition of expelliarmus by [assignee name]

Feel free to think of a few of your own.

Impact

Low

Urgency

Now

Code of Conduct

[X] I agree to follow this project's Code of Conduct

mohan-13 commented 2 years ago

Hi I am interested in picking up this issue. As of my understanding, we will have a Github actions workflow that will be triggered whenever an issue is closed. That workflow will get the title of the issue and the assignee and it will post a celebration message using DISCORD_DEV_WEBHOOK right ? Please let me know if my understanding is correct.

jamesgeddes commented 2 years ago

@mohan-13 That is correct. The DISCORD_DEV_WEBHOOK is a GitHub secret as we clearly cannot publish the raw URL because of all the spam.

The ticket is yours!

By the way, if you are interested in joining us beyond Hacktober, lets have a chat! Just let me know when would be good for you.

mohan-13 commented 2 years ago

Yup! Thanks for assigning it to me. I will get started right away. I would require some info about the API specifications for the WEBHOOK. Let me know how can we connect. Thanks.

jamesgeddes commented 2 years ago

The only info I have on the discord webhooks is on the discord docs. The DISCORD_DEV_WEBHOOK is already connected to our #dev channel in our discord, so feel free to join for testing.

To meet with me via zoom or gmeet, just select a time that would be best for you.

mohan-13 commented 2 years ago

Update: I have worked on this and created a custom action to post the message. Please find the action here. Also, I have added a workflow to the fork of GeekZoneHQ/web repo which consumes the action. Please provide your inputs. Attaching a screenshot of the message in my own channel. [

](url)

jamesgeddes commented 2 years ago

Looks great! You could publish that as an independent GitHub action, then submit a PR to add it to our repo. Remember to add a LICENCE file in your repo - for us to use it we would need it to be GPL compatible. Thanks!