#364 Fix donations with decimals

Freshrojek commented 2 years ago

Description

Added type fixes on getting the donation value and formatting it in a user-friendly manner

Motivation and Context

Before, users could not donate with decimals as it would throw an error. Now Users should be able to donate any amount they want

How Has This Been Tested?

This has been tested through enabling the stripe webhook and verifying the checkout completes.

The stripe tests were run that are already built to confirm the code works

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

jamesgeddes commented 2 years ago

@Freshrojek Looks like you are getting failing tests mate

test_total_with_donation_shows_correct_amount
test_users_with_a_donation_are_sent_to_the_correct_cancel_and_success_urls

Freshrojek commented 2 years ago

@Freshrojek Looks like you are getting failing tests mate
* test_total_with_donation_shows_correct_amount

* test_users_with_a_donation_are_sent_to_the_correct_cancel_and_success_urls

Yup forgot to bring the tests with me :)

jamesgeddes commented 2 years ago

requires #585