GeekZoneHQ / web

Software to power the Geek.Zone website and apps
http://geek.zone/web
GNU General Public License v3.0
19 stars 29 forks source link

fix: move hardcoded automated test passwords to env var #585

Closed jamesgeddes closed 2 years ago

jamesgeddes commented 2 years ago

Description

This change ensures that we are not storing any passwords in the code, regardless of whether they are for testing or not. It moves all testing passwords to the environment variables TEST_USER_PASSWORD andTEST_USER_PASSWORD_BAD`.

Related Issue

resolves #581

Motivation and Context

Sonar repeatedly reports security risks due to our having passwords in plain text in the code. In reality, these are

How Has This Been Tested?

No testing required, only moving two strings into a env vars.

Types of changes

Checklist:

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication