GeekZoneHQ / web

Software to power the Geek.Zone website and apps
http://geek.zone/web
GNU General Public License v3.0
19 stars 29 forks source link

Fix-web-632 fix ignore markdown in ci #634

Closed jamesgeddes closed 1 year ago

jamesgeddes commented 1 year ago

Description

This change takes the simplified approach of only filtering for branch name to see if a CI skip is permitted.

If branch name starts with "doc-" then CI is not required and can branch can be merged, while if branch starts with "junk-" then it will always fail CI, thereby preventing merge.

Related Issue

resolves #632

Motivation and Context

A PR was recently able to be merged without running tests. This prevents that.

How Has This Been Tested?

Has not been tested, but removes code and follows CircleCI documentation regarding filtering on branches.

Types of changes

Checklist:

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jamesgeddes commented 1 year ago

@giulio-giunta geting Internal server error on Snyk?