GeekZoneHQ / web

Software to power the Geek.Zone website and apps
http://geek.zone/web
GNU General Public License v3.0
19 stars 29 forks source link

donation slider done #668

Open ValkovD opened 1 year ago

ValkovD commented 1 year ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ValkovD commented 1 year ago

Hi this is the donation slider i have done.

jamesgeddes commented 1 year ago

@ValkovD I think people have been waiting for you to complete the PR description. Could you do this, please?

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ValkovD commented 1 year ago

Hi James sorry for the late response but just coming back from holiday. Will do this ASAP

jamesgeddes commented 11 months ago

Any update on this @ValkovD?

jamesgeddes commented 8 months ago

@ValkovD I am eager to get this merged as it has been open for a while. We need a description of the change and some screenshots before we can do this. The code looks OK but I am not a front-end person so it would be super to see what it looks like. Thanks!

ValkovD commented 8 months ago

@ValkovD I am eager to get this merged as it has been open for a while. We need a description of the change and some screenshots before we can do this. The code looks OK but I am not a front-end person so it would be super to see what it looks like. Thanks!

Hi James, The donation slider is created as a mini-website with vanilla JavaScript and HTML in one file called donationAndSlider.html This mini app is embedded in the bigger frame register.html according to the structure of this project i tried to follow it as much as possible. The CSS in style.css (theme/static/css/dist/styles.css) makes the slider look almost the same in the different browsers Chrome and Firefox. As I found when testing it without them(-webkit and -moz) slider looks different in different browsers.

This at the bottom is short video of my screen so you can see how it works PS: I also have done the password strength indicator as you can see on this video but i thing it has not been pushed to the repo. Let me know if you want it. Sorry for the delay

https://github.com/GeekZoneHQ/web/assets/98020156/6193142c-fb9a-40d7-80f9-1287d4bb9599

ValkovD commented 8 months ago

As i am thinking now the input value of the donation is encapsulated in the donationAndSlider.html and i dont know how it can be processed to the backend hopefully this isnt a problem. I don`t know how Python Django will render this.

jamesgeddes commented 8 months ago

@ValkovD Looks good, though can you take a look into why it has failed CI please?

ValkovD commented 8 months ago

Will definitely check.

ValkovD commented 8 months ago

I thimk it may be because of line 47 and 48 in the register.html file but not sure as when i try to see the errors in CI it only Loading forever and not showing Screenshot from 2023-12-21 13-10-10