GeekZoneHQ / web

Software to power the Geek.Zone website and apps
http://geek.zone/web
GNU General Public License v3.0
19 stars 29 forks source link

web-685 update eisenhower action to include trigger issue #686

Closed jamesgeddes closed 10 months ago

jamesgeddes commented 1 year ago

Description

The Eisenhower prioritisation issue now requires the triggering issue to be passed in. This provides that.

Only real change is the addition of

GH_ISSUE_NUMBER: ${{ github.event.issue.number }}

Related Issue

resolves #685

Motivation and Context

Makes the action more efficient by only processing the trigger issue. Should prevent us from hitting rate limits.

How Has This Been Tested?

Existing logic not changed, only updates the issues that it processes.

Types of changes

Checklist:

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jamesgeddes commented 11 months ago

@giulio-giunta Ticket prioritization is currently broken without this. May I request your review, please? Also, why is Snyk failing?

giulio-giunta commented 11 months ago

@jamesgeddes, It actually failed again. Can you try updating urllib3 to version >=2.0.6? I solved the problem locally by running python3 -m virtualenv env, then source env/bin/activate and finally snyk test.

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

giulio-giunta commented 10 months ago

@jamesgeddes, This can now be merged. It needed updating the Snyk Github action, along with the version of a couple of dependencies.