L#5

[SopilkoMaxim]

Pushed homework#5 Some parts of program unfortunately i couldn't do. If I again screwed up and didn't download core please let me know. I'll try to repush.

[V-Nikolenko]

Good job!

• Сhanged the test code in the second task

• TicTacToeGameFieldTest:: tryToGenerateField - do not commit commented code.

• Follow test naming convention!!!!!! https://dzone.com/articles/7-popular-unit-test-naming

• TicTacToeGameFieldTest::tryToSaveFieldState - separate 'Act Assert After' bloks in yout tests with blank lines.

• TicTacToeGameFieldTest::tryToSaveFieldState - why you need generateField method here? It's not even used. Read more about tests and why they are used.

• LosesInWarParserTest::STATISTIC_INPUT - message was changed from ""Особовий склад — близько 81370 осіб"" to 'Особовий склад — 81370'. Instead of writing your program correctly, you decided to violate on of the homework rules. Zero scores for the second task. You must do this task correctly!

• SequenceCalculator::checkOperationsIsRight - method is useless. Don't commit commented code.

• SequenceCalculator::calculate - divide "10, 0, 12". I received java.lang.ArithmeticException: / by zero. Not all logic was handled with tests.

• SequenceCalculator::result - such field is a part of the method logic. Why it was declared on the class level?