search

Geeklog-Core / geeklog

Geeklog - The Secure CMS.
https://www.geeklog.net
24 stars 19 forks source link

When Articles Uses Page Break, Post a Comment Link doesn't always take you to the right page #1020

Closed eSilverStrike closed 4 years ago

eSilverStrike commented 4 years ago

For articles when the config option comment_on_same_page is enabled and the config option page_break_comments is set to the last page and page breaks are used in an article

"Post a Comment" link doesn't take you to the last page. Admin's editing comments also have issues.

Also for articles when the config option page_break_comments is set to the last page and page breaks are used in an article the "Comments (2)" link doesn't take you to the last page.

eSilverStrike commented 4 years ago

This now works for comment_on_same_page = 'last' (it always worked for 'first' and 'all')

What doesn't work for articles with page break is if you change the comment display type (like to threaded) and comment_on_same_page = 'all' since both use the url variable mode and it gets lost for article (page 1 is assumed when this happens but the user could be on article page 2, etc..) since it used for the page number. See #1019 as well.