search

Geeklog-Core / geeklog

Geeklog - The Secure CMS.
https://www.geeklog.net
24 stars 19 forks source link

If $_CONF['comment_on_same_page'] is Enabled, it will break plugins that use comments and do not support this option #1033

Closed eSilverStrike closed 4 years ago

eSilverStrike commented 4 years ago

When $_CONF['comment_on_same_page'] was introduced in Geeklog 2.0.0, if enabled it will break plugins that use comments and do not support this config option.

No checks are done by the lib-comment to see if supported so the plugin will end up checking the wrong comment url variables (as a prefix is added to the variables when comment_on_same_page is enabled) making the comment edit form not to work for the plugin.

Related to issues #1019 and #1023

Maybe some check is possible and lib-comment can automatically disable $_CONF['comment_on_same_page'] for plugins that do not support it. If not then we should document this issue in the Config docs.

eSilverStrike commented 4 years ago

Never mind this my mistake. Things should still work....