Geeklog-Core / geeklog

Geeklog - The Secure CMS.
https://www.geeklog.net
25 stars 19 forks source link

Adding "iframe" to HTML Filtering Include config option doesn't allow user to set SRC attribute in content #1078

Closed eSilverStrike closed 2 years ago

eSilverStrike commented 3 years ago

Adding iframe to HTML filtering config option works but when user sets the "src" attribute it gets filtered out.

From the Geeklog Forum: https://www.geeklog.net/forum/viewtopic.php?showtopic=97346#97346

I thought there was a way to set attributes for a tag when added to the filter array but I don't see it in the code or remember how to do it. If there is then we should add this info to the docs.

Assume we need to fix this somewhere in HTMLawed class?

mystralkk commented 2 years ago

I succeeded in adding iframe tag with src attribute in the configuration.

screenshot
eSilverStrike commented 2 years ago

Yup you are right. My mistake, I was thinking that the + just added a new tag not an attribute for that tag. (not sure why as it is kind of obvious)

Since myself and OMAL both missed it I will update the docs to better explain it,