search

Geeklog-Core / geeklog

Geeklog - The Secure CMS.
https://www.geeklog.net
25 stars 19 forks source link

Check Geeklog and Plugins compatibility with PHP 7.4 and PHP 8 #1079

Closed eSilverStrike closed 2 years ago

eSilverStrike commented 3 years ago

Haven't looked at 8 yet so not sure of the changes...

eSilverStrike commented 3 years ago

Webservices has some PHP warnings for PHP 7.3+

See forum post: https://www.geeklog.net/forum/viewtopic.php?showtopic=97380

When I try to edit or add a new story I get the following error,

A PHP error has occurred: (This text is only displayed to users in the group 'Root') E_WARNING(2) - "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? @ /home/system/lib-webservices.php line 577

mystralkk commented 3 years ago

Webservices has some PHP warnings for PHP 7.3+

See forum post: https://www.geeklog.net/forum/viewtopic.php?showtopic=97380

When I try to edit or add a new story I get the following error,

A PHP error has occurred: (This text is only displayed to users in the group 'Root') E_WARNING(2) - "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? @ /home/system/lib-webservices.php line 577

Fixed with change set e6a1e1f.

eSilverStrike commented 3 years ago

We will have to check the Geeklog install, upgrade and migrate processes as well to make sure they are compatible with PHP 7.4 and 8.

An install issue that seems to deal with PHP 8 was found. See #1087

mystralkk commented 2 years ago

Created a new repository for plugin information: https://github.com/Geeklog-Core/Plugin-Compatibility-List . Feel free to update the list, please.

mystralkk commented 2 years ago

I have updated many of the plugins in https://github.com/Geeklog-Plugins to work with Geeklog 2.2.2 and PHP 8.1. Are there any other plugins we would like to have work with Geeklog 2.2.2 and PHP 8.1?

eSilverStrike commented 2 years ago

Great! 👍

All the plugins I have been releasing with Geeklog should have a repository in that list.

Did you double check the forum? I can't remember if I did but I do see it is marked as Yes in the compatibility list

https://github.com/Geeklog-Core/Plugin-Compatibility-List

mystralkk commented 2 years ago

I haven't fully checked the Forum yet with Geeklog 2.2.2 and PHP 8.1, but the plugin mostly seems to be working well. I will look into it later.

eSilverStrike commented 2 years ago

It should be I was doing some work with it before I believe using PHP 8.0.

mystralkk commented 2 years ago

I changed a few places, and the plugin is working fine with PHP 8.1.