Geeklog-Core / geeklog

Geeklog - The Secure CMS.
https://www.geeklog.net
25 stars 19 forks source link

Hidden is not saved in Topic Editor #1097

Closed 0MAL closed 2 years ago

0MAL commented 2 years ago

Hidden is not saved in Topic Editor

topichidden

.

mystralkk commented 2 years ago

You cannot hide root topics. Does this happen with child topics as well?

eSilverStrike commented 2 years ago

I tested and was able to hide all child topics. Top level Topics (those in the root) cannot be hidden since they are the top level and do not have a parent. Hiding them would prevent a user from being able to select the topic and any topic below it.

Did I miss something in my testing Omal and are there cases where it doesn't work?

mystralkk commented 2 years ago

Maybe Omal tried to hide top-level topics in vain. If this is the case, this issue is not a bug, but we should have to make it clear that you cannot hide top-level topics in the topic editor.

eSilverStrike commented 2 years ago

Yup. The current label sort of does at it mentions a parent topic but it may not be super clear.

0MAL commented 2 years ago

Did I miss something in my testing Omal

eSilverStrike commented 2 years ago

1) "Topic will be hidden in the Topic Block until it's Parent Topic is selected" (current label)

2) "Topic will be hidden in the Topic Block (if this Topic is a Child) until it's Parent Topic is selected"

3) "Topic is displayed in Topic Block only when Parent Topic is selected"

Hard to describe feature without a tool tip but I think number 3 is the best option.

mystralkk commented 2 years ago

I agree number 3 is best. In addition, it would be better to hide the "Hide" checkbox when the user selects the ROOT topic with the help of JavaScript.

mystralkk commented 2 years ago

Implemented JavaScript part with change set 344b7512ce19dac13b6d95d6e4696f82f0234397.

eSilverStrike commented 2 years ago

Noticed an issue. The hidden checkbox is not visible on the edit form when the page first loads up for a child topic. It only becomes visible if I change the parent topic select box.

mystralkk commented 2 years ago

Fixed with change set 44781124da693194620f5b93e5c0805098a4971c.