Geeklog-Core / geeklog

Geeklog - The Secure CMS.
https://www.geeklog.net
24 stars 19 forks source link

[Bugs] Review / redesign censoring of posts (articles, comments, etc.) #541

Open mystralkk opened 8 years ago

mystralkk commented 8 years ago

Reported by @dhaun on 25 Sep 2011 17:08

Version: 1.8.0

Description: Looking into bugs #538 and #539 brought up some general problems with how censoring of content is currently implemented. Specifically

As a rule, I think content should always be saved uncensored and any filtering should only be applied when displaying it. That would allow changing rules afterwards and also allow content to be viewed in different modes, e.g. Admins could see the uncensored version for review purposes.

From a technical point of view, simply running COM_checkWords() over the story text (for example) is too simplistic: It will then also censor URLs and HTML attributes, which results in broken links and invalid HTML.

Steps To Reproduce: With bug #538 not resolved yet, adding "ass" to the list of censored words can have interesting effects on e.g. the class attribute in HTML or a link to the Wikipedia article about the French composer Massenet ...

Mantis Bugtracker #1395

mystralkk commented 8 years ago

Related to #538

mystralkk commented 8 years ago

Related to #539

mystralkk commented 8 years ago

Related to #194