Geeks-Solutions / vue-sections

This npm package provides a VueJS Component to use right off the bat to interface with Sections' server
https://sections.geeks.solutions
2 stars 3 forks source link

Layout drop down and checkbox display adjustment plus small adjustment for empty section #121

Closed akramsarkis closed 1 year ago

akramsarkis commented 1 year ago
Screenshot 2023-10-05 at 11 19 11 Screenshot 2023-10-05 at 11 24 41 Screenshot 2023-10-05 at 14 07 53 Screenshot 2023-10-05 at 14 11 01

Acceptance testing

mahfouzhseineweev commented 1 year ago

@akramsarkis

When you click on the button to edit the layout, the layout drop down list and the highlight region option will show and the other buttons will swipe to the right

akramsarkis commented 1 year ago

@akramsarkis

When you click on the button to edit the layout, the layout drop down list and the highlight region option will show and the other buttons will swipe to the right

  • The layout drop down and the highlight region option will be still to the of the Restore button, correct ?
  • What do you mean exactly by other buttons will swipe to the right
  • The layouts drop down and the highlight region option will be hidden by default and they will show after pressing the edit layout button. However what happens after ? I mean re-clicking in the edit layout again will make the drop down and the highlight option disappear ?

@mahfouzhseineweev

akramsarkis commented 1 year ago

@mahfouzhseineweev , there is one more point to fix that is the Restore option, if I saved the page with layout 2 for example and then I move to standard without saving and I click on restore it should restore me the layout 2 that was saved last thing

akramsarkis commented 1 year ago

Hello @mahfouzhseineweev , I have one feedback, when I add an empty section, let's have the option of the section showing completely, nos they are truncated

Screenshot 2023-10-09 at 10 27 45
akramsarkis commented 1 year ago

Hello @hussein661 ,

If I add one empty it is fine , but if I add several the one before the last one are truncated as well

Screenshot 2023-10-10 at 14 18 28
mahfouzhseineweev commented 1 year ago

Hello @akramsarkis ,

That last reported problem is completely normal, adding multiple empty sections that has zero height will result to the above and the user can safely delete the empty section by pressing on the icon that will always show after the last update. I am quite sure the user will not need empty sections in his page.

A solution for this would be to give the section view a predefined height which is not optimal given that the section should have the height of its content, let me know what you think.

akramsarkis commented 1 year ago

Hello @akramsarkis ,

That last reported problem is completely normal, adding multiple empty sections that has zero height will result to the above and the user can safely delete the empty section by pressing on the icon that will always show after the last update. I am quite sure the user will not need empty sections in his page.

A solution for this would be to give the section view a predefined height which is not optimal given that the section should have the height of its content, let me know what you think.

Hello @jfayad ,

Please to check the comment above . Can we keep it as the picture below ? Indeed this is not a regular case, it should not happen in the real life to add several empty sections, and the user can still access the options even though they are not showing totally. Please to let us know:

273881552-b9b4f7bb-3432-4650-a5bf-444e11b36498
jfayad commented 1 year ago

Indeed, this is quite an usual situation and doesn't need to be tackled urgently.

akramsarkis commented 1 year ago

Indeed, this is quite an usual situation and doesn't need to be tackled urgently.

Ok, i will open then separate issue for it and close this one

akramsarkis commented 1 year ago

Here the issue : https://github.com/Geeks-Solutions/vue-sections/issues/122