search

GeeksHacking / hackomania-2024-website

Static website built with Astro and React
https://hackomania2024.geekshacking.com
MIT License
0 stars 0 forks source link

Add new banner #20

Closed lyqht closed 9 months ago

lyqht commented 9 months ago

Closes #12

Design: https://www.figma.com/file/f2SBsTMRRJfZut5dOZFyNs/Website-UI?type=design&node-id=31-251&mode=design&t=NmBHdOaj09Dw0fO5-0

Demo

Desktop

CleanShot 2024-02-18 at 16 37 58@2x

Mobile

CleanShot 2024-02-18 at 16 37 39@2x

Alternative implementation can be found at #19, where the scale will look more accurate, but the code is much more un-maintainable.

qin-guan commented 9 months ago

Was wondering why you closed the other PR just now hahaha, now I see! Feel free to merge in whichever you prefer. Considering we won't be touching this much frankly maintainability might not matter too much hahaha 😂

lyqht commented 9 months ago

i think it's easier to debug the code in this PR if we ever need to update it again, so let's merge this instead