search

Geeksltd / GCop

GCop packages
https://geeksltd.github.io/GCop/
24 stars 8 forks source link

GCop 651 #269

Open marjanjavid opened 5 years ago

marjanjavid commented 5 years ago

no warning is kicked

marjanjavid commented 5 years ago

The written example for this rule was wrong. I created a unit test for this rule on https://gitlab.com/Paymon/GCop/commit/12ae6a86776bdbf15af1f3385681c19e38b4ec69

Karvan commented 5 years ago

@marjanjavid why this rule is in "Pre-Release"?

Is this a new rule or have we updated the logic?

marjanjavid commented 5 years ago

@Karvan This rule is still in Development branch, but as I have finished their task I moved theme to "Ore-Release" column in the work plan. I just added a new unit test for this rule. This is not a new rule , nor updated logic. Should I bring it back to the "In progress" column?

Karvan commented 5 years ago

While it's not about the development (new rule, bug, updating logic behind a rule) it shouldn't be in GCop Project kanban it must be in GCop Documentation.

And while you need to work on that it must be In Progress.