Geeksltd / Olive

Olive framework, for more productive cross platform .NET solutions. It's available under the GPL v3 license. See License.md for more information.
https://geeksltd.github.io/Olive
Other
44 stars 44 forks source link

String's MinLength - Incorrect property referenced in validation text #242

Closed ShivSGeeks closed 5 years ago

ShivSGeeks commented 5 years ago

The recently added MinLength (made available for String properties) has a minor issue, where the validation text it shows is always referencing the String property's Max length ("200" by default) instead of its Min length.

For reference, here is what is defined in the Model (with one of the properties also having a Max value defined): minlengthtext-2

And what is generated by M# for that specific property: minlengthtext-3

And what is shown when the application is running: minlengthtext-1

Also, this is with the project's Olive and M# Nuget packages all up to date.

ShayanAtGeeks commented 5 years ago

Test again with the new M# nuget in 15 mins.

Regards,

Paymon Khamooshi Technology Director

T: +44 (0) 845 643 6229 M: +44 (0) 777 279 8509

On Wed, Feb 20, 2019 at 2:55 PM ShivSGeeks notifications@github.com wrote:

The recently added MinLength (made available for String properties) has a minor issue, where the validation text it shows is always referencing the String property's Max length ("200" by default) instead of its Min length.

For reference, here is what is defined in the Model (with one of the properties also having a Max value defined): [image: minlengthtext-2] https://user-images.githubusercontent.com/45559659/53099622-16d72400-351e-11e9-8a66-1d39e9d9e000.png

And what is generated by M# for that specific property: [image: minlengthtext-3] https://user-images.githubusercontent.com/45559659/53099642-1dfe3200-351e-11e9-9b11-d0548078948a.png

And what is shown when the application is running: [image: minlengthtext-1] https://user-images.githubusercontent.com/45559659/53100027-ecd23180-351e-11e9-88cb-6b295a506498.png

Also, this is with the project's Olive and M# Nuget packages all up to date.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Geeksltd/Olive/issues/242, or mute the thread https://github.com/notifications/unsubscribe-auth/AWiwrEmebZu_1BLKUK5jJusjQv-tjzwLks5vPWHAgaJpZM4bFZrT .

--

Geeks Ltd

Accelerating Business Innovation via Smart_ Software Development _www.geeks.ltd

​ CONFIDENTIALITY & DISCLAIMER: This message and any attachments are confidential, proprietary, and may be privileged.  If this message was misdirected, Geeks Ltd does not waive any confidentiality or privilege.  If you are not the intended recipient, please notify us immediately and destroy the message without disclosing its contents to anyone.  Any distribution, use or copying of this e-mail or the information it contains by other than an intended recipient is unauthorized. Any offer or acceptance contained within or implied by this Email message is made Subject to Contract, Additionally, where this Email message is sent in connection with a contentious issue, the contents are Without Prejudice.

ShivSGeeks commented 5 years ago

Checked with the new M# nuget udpate and can confirm that it is now showing the validation information correctly:

minlengthtext-04 minlengthtext-05 minlengthtext-06

Consider this issue now resolved.