Closed qwksilver closed 4 years ago
qwksilver
commented
4 years ago adding to 36a I've noticed a lot of things, like hitting save on the playlist screen, reverts the playlist to the beginning of the sequence, I've also noticed quite a few times it seems like my "shuffle mode on" just stops being "on", which is what lead to the need for 36b, since we can't tell our current settings from the settings screen unless it's something with a number.
Geektoolkit
commented
4 years ago Thanks for the quick turnaround, glad I got it back to stable. 2.08 was a huge rewrite to clean things up properly so we could make forward progress. in 2.08 I narrowed my fixes to just rewriting the infobar code. Thanks also for the suggestion of having it be mode based...that cleaned things up immensely once I let go of the concept of 'clock on/off' and then trying to juggle the rest.
36a - Unless you strongly disagree, going to mark this as won't fix. To keep the system stable, anytime a change is made on the settings page, I go through and basically 'internally restart' the system. This means I re-read all of the settings, reset the playlist, etc. My thinking is that someone should not change settings often, and once they're there, they should stay that way for a bit (outside of the control section to change images on the fly and such). I'm worried if I get fancy here and try to only refresh the image setup I may jeopardize that. I'd rather put time into closing down some of the other issues and taking a look at webm/gif type features.
36b. you're right, this has bugged me for a while. I've avoided it because I was thinking I'd have to write out the html from the engine (vs. storing it in the html file under the web folder...which is where I like it). I like the idea of just listing the current setting...it's clean, and easy to do, and I think that'll get the point across at least. 36c. I'll have to see why this is...this is supposed to be covered by the same design that causes 36a.
21i - playlist deletions - This just sounds broken. I'll narrow down and attack it.
21e - I thought I had this fixed, I'll see if I can get a repro of it. 9 - I'll take another stab at this. The whole migration thing is tricky. 8b - web/gif - I'm hoping to take a stab at these sooner than later. They likely won't fade properly as I'll be using other apps. I'll see. 24 - should be simple now, I'll try to get it into the next build 23 - I really want this sooner than later, as it'd be an amazing feature for a youtube video I want to make about the updates to this. I'll see if I can get it coded up in a compartmentalized way that I can turn it off if it destablizes too much. 18 - I've actually put hours into blurboxing, and think I have a way forward for it, but it's risky code. Going to hold off for a bit longer.
8/21a - Going to live with these for a while.
Thanks again for your hard work, I feel like we've got a lot of goodness in. I'll be excited when webm/gif, blurboxing, and mutli-sync are in. I may then look at promoting the version to 2.5. The home automation hooks are actually going in behind the scenes as well. Should be some super cool scenarios once that's all going.
qwksilver
commented
4 years ago 36a, will become unimportant if we get the web control to select file/clock/info/hide. the problem in it with reseting playlist is that if you want the filename of the picture you are on, it restarts the sequence before you see the file name.
36c, to clarify this better is not picking up external changes, like adding the new directory on dropbox, have rclone bring it in, but without reboot that new directory doesn't show in the playlist list.
21e, most of this is fixed. if you look at the photo in this post 21-7 and see that sliced edge, go on keyboard and go from file to clock to info to wherever and you'll see artifacts that remain on the other size of that sliced edge line.
9, still a fan of settings just being a list of used variables, so that if more is read from the file than the version uses, it's no big deal, and any variable missing is added in with it's default. ergo load all default variables, load settings variable over those defaults, then resave the settings, then act on it all. the resave process will ultimately discard anything that wasn't in that version.
8b, will be nice to generate a plug n go environment, but with the tutorials to convert things and make loops, it's not that critical to curate the more important parts of the library at this point.
24, once implemented will automatically eliminate the need to change the 36a behaviour
23, how about starting with a simple multi-screen settings page, with a few things, ideas in a sub-post on #23.
18, fork section and a way to download a running fork for testing, especially if you have most of the code figured out, it may save it in a working form to reference later.
Perhaps go to 2.1 rc-stable, with only the extra web control buttons. (info, file, clock, hide, maybe shutdown now, reboot or restart if feasible at all). Then begin testing towards 2.2 for another minor rc. and so on. then 3.0 will be the big reveal point,
ps if there is a moderator promotion you can give a user, I would be willing to close out duplicates while revising.
Geektoolkit
commented
4 years ago qwksilver I'm sorry I'm new to github and didn't even think about that! I added you as a collaborator, please let me know if that gives you enough permissions to do what you need. You've been amazing help on this and I'll make sure you're credited appropriately. I'm reading through the rest of the above.
qwksilver
commented
4 years ago no worries and yes collab did activate the needed permissions, be warned that it also grants push access, which since i don't code i wouldn't use anyway, but others might and you might want to see what all controls are available there.
qwksilver
commented
4 years ago 2.10 36a irrelevant now, 36c resolved with webui update file list button, 8 delisted may revisit someday 21a delisted may revisit someday 9 i've migrated up two versions from 2.07 to 2.09 then to 2.10, i know issues exist in earlier versions, and in trying to downgrade,
confirmed to still exist in 2.10 21i unchanged behavior (migrating to seperate issue) now #38 21e, most of this is fixed. if you look at the photo in this post 21-7 and see that sliced edge, go on keyboard and go from file to clock to info to wherever and you'll see artifacts that remain on the other size of that sliced edge line.
Geektoolkit
commented
4 years ago I did a quick revisit of webm/gif. Glad to punt those for now.
21i - Tracked this down, will be fixed in next build. For 21e, I got a repro of the sliced edge...does that stay there for you or is it temporary? I'm seeing it dissapear in about 500ms or so (which would line up with my refresh time). I'm wondering if it's a rendering artifact, but if it's disappearing for you then I'm glad to wont fix that permanently (mainly because I don't think I can fix it in my code).
Item 9 I'm going to take another stab at before the next release.
qwksilver
commented
4 years ago 2.11 resolves 36b, 21e deleted as unfixable at this time fixed 2 unlabeled bugs, in release notes
(36d) setting issues were all somehow around "Should Videos Play Audio (Current value: On )Off" if it's included it doesn't want to save it, I was able to go from off to on, but not back to off. also settings screen not as fast as before if you don't give it a minute to "save" before clicking on the settings box to open the screen again it tends to scrap quite a few changes.
(36e) new function wouldn't open file then pause, it just always went straight to "paused" it would do this even if blank after the SETFILE= NOTE: in my testing I was trying to define a "/home/pi/Pictures/Friends/Emily/be1.jpg" and being very specific about the path. I was never able to advance to an actual picture, i also tried with out the home/pi and with a "../" and a few other varients.
other issues moved to completed side of list to narrow remaining todo list.
Geektoolkit
commented
4 years ago Ah, ok I had the 'remove settings' bug locked down, then threw in the 'lets show settings for the radio buttons' code. I had everything working well, then hit a point where i couldn't save anything, tore through the code and couldn't figure out what I changed that broke it. I attacked a few areas I thought might've caused it. Your comment about the audio comment is gold, that will help me figure out what's going on there.
I'm going to add some extra logging around setfile. I was pausing it on purpose to go into a 'manual' mode but I'm going to scrap that and just have set file set an image, and let the frame do it's normal transitions. I'll have added logging to help track down when it fails.
I actually threw a lot of the sync code in last night. It doens't take effect unless a synced frame is registered, so it should be mostly harmless. 2.12 should be good. I'll go track down that setting bug. I can work on perf after I get the sync settings in.
Geektoolkit
commented
4 years ago As of 2.12:
I'm looking into blurboxing now. I have 3 frames synced (I'm using a 65" tv for one of them) and it's been really fun to see. I may have to build wood frames to get them to match up with the TV's depth.
Geektoolkit
commented
4 years ago qwksilver
commented
4 years ago Remaining Issues Migrated to #45
2.11 unstable testing edition.
2.10 has really minor issue with a 1 min delay on reboot, and is otherwise performing as well as 2.09 and can also be moved to release status
2.09 is a really stable version, it migrated well from 2.07 which is where I was parked for a bit. No new items are actually crash/instability issues. I ran down the last punch list and punished the system a good deal, and couldn't break it or lock it up, even deleting all directories from the playlist screen didn't actually crash it. I recommend this as a release candidate level.
New Item/Observation From comments bellow:
List Migration incorporates list items from other items for links (Ranked by Priority, or close :>)
2.10 Resolved/Deleted
21e : Bug Font placement not properly accounting for font size, notes below#8 a : Video Crossfade (kinda awkward since no photo behind it)21a : Bug, visual, minor, on the playlist screen, if there is more than one directory, then the first directory [+] expand marker is offset forward slightly from the rest of the list.items in bold have been requested, noticed more than onceshow clock immediately "advances" but resets to beginning of playlist order.