GeekyAnts / NativeBase

Mobile-first, accessible components for React Native & Web to build consistent UI across Android, iOS and Web.
https://nativebase.io/
MIT License
20.15k stars 2.38k forks source link

StyleProvider/theme does not support hot reload #1227

Closed elnygren closed 3 years ago

elnygren commented 6 years ago

It seems that StyleProvider in native-base-shoutem-theme does not support hot reload: https://github.com/GeekyAnts/NativeBase/issues/910 https://github.com/GeekyAnts/NativeBase/issues/1216 https://github.com/GeekyAnts/NativeBase/issues/772

tldr: changing theme variables has no effect after hot reload, a full reload is necessary. This might or might not be related to react-navigation.

This makes development with NativeBase extremely tedious because you either have to: a) suffer and edit styles with full reloads b) subclass everything (Card -> MyCard extends Card) and style them without using themes

What would it take to get this support? Is there some workaround? I'm going to have to drop NativeBase from my project (and recommend everyone to do the same) if there isn't a good solution to this.

Here's an example of a UI framework for React Native that does implement theming of components with hot reload support. https://github.com/akveo/react-native-ui-kitten and https://github.com/akveo/kittenTricks

jariwalabhavesh commented 6 years ago

@SupriyaKalghatgi Any update on this issue (solution)

josephbuchma commented 6 years ago

There is this thing under development, which looks very promising http://nativebase-customizer.geekydev.com/ Does not solve the problem, but should reduce pain quite a bit.

WilGatlin commented 5 years ago

@elnygren This manual clear works great: https://github.com/GeekyAnts/theme/pull/5

But needs to be merged and has been outstanding for a while.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Lurtroxx commented 1 year ago

Any update to this???