GeekyAnts / NativeBase

Mobile-first, accessible components for React Native & Web to build consistent UI across Android, iOS and Web.
https://nativebase.io/
MIT License
20.16k stars 2.38k forks source link

Fontisto Icon missing #3063

Closed mrkpatchaa closed 4 years ago

mrkpatchaa commented 4 years ago

Issue Description

Fontisto is not included in icons. Font file is present and linked but IconNB is not importing it. https://github.com/GeekyAnts/NativeBase/blob/3924fa6b901b5d3cc315be64ffe11a9b8392556e/src/basic/IconNB.js

I get this error :

Warning: Failed prop type: Invalid prop `type` of value `Fontisto` supplied to `IconNB`, expected one of ["AntDesign","Entypo","EvilIcons","Feather","FontAwesome","FontAwesome5","Foundation","Ionicons","MaterialCommunityIcons","MaterialIcons","Octicons","SimpleLineIcons","Zocial"]
hanykumar commented 4 years ago

Hi @rmkpatchaa , we have fixed this issue and it is available on master branch now. Thanks

hanykumar commented 4 years ago

Hi @rmkpatchaa , latest version of Native base has been released. The issues should be fixed now. Native Base 2.13.12

amar1n commented 4 years ago

Hi, I have the same issue with...

Unable to resolve "@expo/vector-icons/Fontisto" from "node_modules/native-base/dist/src/basic/IconNB.js"

Maybe I missed something or the issue is not resolved at all.

Here you can see more people with the same problem

Thanks in advandce!

mrkpatchaa commented 4 years ago

I've tested the new version and icons are showing but i'm still getting the warning. But now Icons are showing.

amar1n commented 4 years ago

Every works fine with native-base: 2.13.8

The problem appears in version ^2.13.8 and remains until 2.13.12

Unable to resolve module @expo/vector-icons/Fontisto from .../node_modules/native-base/dist/src/basic/IconNB.js: Module @expo/vector-icons/Fontisto does not exist in the Haste module map

amar1n commented 4 years ago

In short, what you need to install is the exact 2.13.8 version

npm i --save-exact native-base@2.13.8

sankhadeeproy007 commented 4 years ago

Yes, until expo upgrades to add fontisto, using 2.13.8 seems to be the best bet.