search

GeekyAnts / flick-video-player

MIT License
265 stars 267 forks source link

[Web] Canvaskit Rendering Does Not Open Fullscreen Properly #84

Closed msoham123 closed 3 years ago

msoham123 commented 3 years ago

image

When I hit the fullscreen button on the FlickVideoPlayer widget, it expands to fill the screen but does not go into fullscreen. If I manually hit F11, it goes into full screen and replicates the expected behavior?

Is there a widget setting I am missing or is this just genuinely not working as intended on CanvasKit?

geekruchika commented 3 years ago

Still, we have to make the player compatible with the web. If you are working on it, PRs are always welcomed!!🙂

msoham123 commented 3 years ago

@geekruchika I'll see what I can do but I'm not super familiar with WASM and low-level web rendering things so I don't think I could make a PR as of now. I'll keep this up so that if someone who knows how to approach this can take a look at it.

mrinaljain commented 3 years ago

Hello @msoham123 I'm facing the same issue , did you tried the html render ?

msoham123 commented 3 years ago

@mrinaljain No, I haven't. I would like to use the canvaskit renderer if possible, as it is more performant when it comes to scrolling.

This issue might be fixed once https://github.com/flutter/flutter/issues/80524#issuecomment-840920225 goes into master. We'll see.

ditman commented 3 years ago

https://github.com/flutter/flutter/issues/80524 has been merged into Flutter channel master. I hope it helps with this issue!

msoham123 commented 3 years ago

I just tested it with the new fix. The problem still persists. The issue is not that fullscreen is not working. The issue is that the implementation of fullscreen covers the entire browser view instead of going into "expected" fullscreen.

image

For example, when you go into fullscreen, you shouldn't be able to see any of my tabs or bookmarks.

geekruchika commented 3 years ago

Please try this version. It's still in development but you can able to toggle fullscreen. https://pub.dev/packages/flick_video_player/versions/0.4.0-dev.1

msoham123 commented 3 years ago

@geekruchika Fullscreen is still not working on latest master and version 0.4.0-dev.1.

Flutter 2.4.0-5.0.pre.109 • channel master • https://github.com/flutter/flutter.git Framework • revision 0874e421f7 (44 minutes ago) • 2021-07-20 13:46:04 -0400 Engine • revision f0325b6a3d Tools • Dart 2.14.0 (build 2.14.0-332.0.dev)

The player attempts to fullscreen but stops.