search

GeekyAnts / flutter-carousel

A carousel package in flutter with various configuration options
Other
66 stars 29 forks source link

Disable wrapping from either end of list #3

Closed JoshRice1 closed 4 years ago

JoshRice1 commented 4 years ago

Added the ability to specify if the carousel should wrap. The default is to allow as this is the current functionality and is backward compatible.

JoshRice1 commented 4 years ago

@jaiswalshubham84 So about this pull request? Is it something you think you would merge in or is there some problem with it that you would like to see fixed before you merge it in?

jaiswalshubham84 commented 4 years ago

Hi Josh, first of all sorry to reply you so late. I actually didn't see the merge request. Most Probably in a week, I will review and merge the code. Thanks for contributing.

On Thu, Dec 12, 2019 at 7:46 PM Josh notifications@github.com wrote:

@jaiswalshubham84 https://github.com/jaiswalshubham84 So about this pull request? Is it something you think you would merge in or is there some problem with it that you would like to see fixed before you merge it in?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GeekyAnts/flutter-carousel/pull/3?email_source=notifications&email_token=AHWEY7J6HUDXT6TIS3XMGF3QYJBSFA5CNFSM4JZD4KRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGWZLOQ#issuecomment-565024186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHWEY7I6QPYOGJUPPEFKXRTQYJBSFANCNFSM4JZD4KRA .

-- Thanks & Regard, Shubham Kumar

JoshRice1 commented 4 years ago

Cool and thanks not huge hurry or anything just wanted to get a pulse on it. There were a couple of other things that I think could be discussed and improved upon that would make usage better in some ways but, some may be breaking changes) while others would just be less code duplication.

JoshRice1 commented 4 years ago

So any update on this?

JoshRice1 commented 4 years ago

So over a month ago, you said a week. I need to get a response on this and have it merged in or I need to go a different direction @jaiswalshubham84

jaiswalshubham84 commented 4 years ago

@JoshRice1 Your pull request has been merged. Looking forward to a new version release with some additional features along with yours. Keep on contributing 👍

jaiswalshubham84 commented 4 years ago

Hi Josh, Your pull request has been merged. Looking forward to a new version release with some additional features along with yours. Keep on contributing 👍

On Tue, Jan 28, 2020 at 6:28 PM Josh notifications@github.com wrote:

So over a month ago, you said a week. I need to get a response on this and have it merged in or I need to go a different direction @jaiswalshubham84 https://github.com/jaiswalshubham84

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GeekyAnts/flutter-carousel/pull/3?email_source=notifications&email_token=AHWEY7IYSVCA7R2VGVTV3CLRAATW5A5CNFSM4JZD4KRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKDGL6Y#issuecomment-579233275, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHWEY7PJS524ASMWISMCMM3RAATW5ANCNFSM4JZD4KRA .

-- Thanks & Regard, Shubham Kumar

JoshRice1 commented 4 years ago

So I have been checking here and there but pub.dev doesn't seem to be updated and doing an upgrade packages doesn't pull anything new. Were you planning to release soon? Also, I notice the example doc says to put "flutter_multi_carousel: ^1.0.0" this isn't even the most current version published so you might want to update that.