search

GeekyAnts / react-native-seed

Get your favorite boilerplate of React Native
http://ReactNativeSeed.com
652 stars 15 forks source link

Upgrading NativeBase reference (and potentially theme files?) #8

Open hardcodet opened 6 years ago

hardcodet commented 6 years ago

Hi all

First of all: Thanks for this project - it helped me a lot to get started with RN :)

Quick question: I've seen that you are bootstrapping quite a few custom files for the theme (the variables and components folders). At the time I setup my project, you were bootstrapping the project to install NativeBase 2.3.3, with the most current version being 2.3.5. Is there anything I need to consider before upgrading NativeBase in order not to break anything now or further down the line?

shivrajkumar commented 6 years ago

@hardcodet There won't be any issue if you upgrade the Nativebase version. The variables remains same with upgrades with the inclusion of new ones if required. In that case you can just merge or copy the new variables. You can refer to the release notes for any breaking changes here. Also , all the variations are upgraded for latest version of RN and v2.3.5 of Nativebase

kikoseijo commented 5 years ago

Will be nice to have libraries updated, been a wile since, we on native base .12. For example, iphoneX heights are not taken care under this current build now.

Nice package by the way.